test: skip test-child-process-pipe-dataflow.js on Windows#49563
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Sep 11, 2023
Merged
test: skip test-child-process-pipe-dataflow.js on Windows#49563nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
This is constantly failing on Windows now that the CI is never green there. To give CI at least some green space, mark it as SKIP, because we've been practically ignoring the failure for months anyway, and will probably just continue doing that.
nodejs-github-bot
added
needs-ci
Member
Author
|
As #48300 mentioned the issue comes from cygwin, my guess is if we really want to fix it, the test needs to be re-written to stop relying on that, but it's probably not a bug that needs to be fixed in core as it worked with older versions of cygwin. In case like this, if no one takes the test up, I think we should just skip it (I don't really know how to/want to deal with cygwin quirks, so I propose we just skip it on Windows, IMO a test was just not written with Windows in mind if it counts on how |
lpinca
approved these changes
Sep 8, 2023
Member
MoLow
approved these changes
Sep 9, 2023
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
This was referenced Sep 10, 2023
targos
approved these changes
Sep 11, 2023
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in b0edb28 |
This was referenced Sep 12, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
This is constantly failing on Windows now that the CI is never green there. To give CI at least some green space, mark it as SKIP, because we've been practically ignoring the failure for months anyway, and will probably just continue doing that. PR-URL: #49563 Refs: #48300 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
This is constantly failing on Windows now that the CI is never green there. To give CI at least some green space, mark it as SKIP, because we've been practically ignoring the failure for months anyway, and will probably just continue doing that. PR-URL: nodejs#49563 Refs: nodejs#48300 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is constantly failing on Windows now that the CI is never green there. To give CI at least some green space, mark it as SKIP, because we've been practically ignoring the failure for months anyway, and will probably just continue doing that.
Refs: #48300